Adding support for inherent reactions in Mixer and Separator #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewlee94
added
bug
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1289 +/- ##
==========================================
- Coverage 77.41% 77.41% -0.01%
==========================================
Files 390 390
Lines 63388 63402 +14
Branches 11649 11658 +9
==========================================
+ Hits 49071 49080 +9
- Misses 11792 11796 +4
- Partials 2525 2526 +1 ☔ View full report in Codecov by Sentry. |
MarcusHolly
approved these changes
Nov 17, 2023
|
Will test that this works with the UKy flowsheet after its merged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes None
Summary/Motivation:
In developing a flowsheet for PrOMMiS, it was discovered that the Separator model had a degrees of freedom issue when separating streams including inherent reactions. Investigation revealed that the Separator material balances needed to include generation terms for the inherent reactions, and that this issue also exists in the Mixer.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: